Fix productivity-suite-react-ui-server build failure #2317
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ZePan110 <[email protected]>
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a build failure in the productivity-suite-react-ui-server by adding the --legacy-peer-deps flag to the npm install command in the Docker build process.
- Modifies the npm install command to include the
--legacy-peer-depsflag to resolve dependency conflicts
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
|
|
||
| RUN ["npm", "install"] | ||
| RUN ["npm", "install", "--legacy-peer-deps"] |
There was a problem hiding this comment.
Using --legacy-peer-deps is a temporary workaround that bypasses npm's stricter peer dependency resolution. Consider updating the package.json dependencies to resolve conflicts properly or documenting why this flag is necessary for long-term maintainability.
Suggested change
| RUN ["npm", "install", "--legacy-peer-deps"] | |
| RUN ["npm", "install"] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix productivity-suite-react-ui-server build failure
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
https://github.com/opea-project/GenAIExamples/actions/runs/18895081223/job/53930663132