Fix exception in UnityTransport when DisconnectLocalClient was called #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exception was the following: ArgumentOutOfRangeException thrown by HandleTransportDataEvent called by ReceiveMessages called by ProcessEvent called by ShutdownInternals called by DisconnectLocalClient() Since the exception arose when trying to handle data events while m_State is Disconnected, I removed the m_State = Disconnected from the DisconnectLocalClient() method. ShutdownInternals already sets the m_State variable to Disconnected after it's down handling events.
|
To reproduce the issue, you could simply have the server shutdown and frequently the clients would get this error. |
|
Let me know if the change makes sense to you @ooonush |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exception was the following:
ArgumentOutOfRangeException
thrown by HandleTransportDataEvent
called by ReceiveMessages
called by ProcessEvent
called by ShutdownInternals
called by DisconnectLocalClient()
Since the exception arose when trying to handle data events while m_State is Disconnected, I removed the m_State = Disconnected from the DisconnectLocalClient() method. ShutdownInternals already sets the m_State variable to Disconnected after it's down handling events.