Preserve catalog path in metadata for multi-ontology-input commands - #1285
Open
balhoff wants to merge 1 commit into
Open
Preserve catalog path in metadata for multi-ontology-input commands#1285balhoff wants to merge 1 commit into
balhoff wants to merge 1 commit into
Conversation
matentzn
reviewed
Aug 27, 2026
| for (String inputOntologyIRI : inputOntologyIRIs) { | ||
| inputOntologies.add( | ||
| ioHelper.loadOntology(IRI.create(inputOntologyIRI), catalogPath, inputFormat)); | ||
| return getInputOntologiesWithMetadata(ioHelper, line, catalogPath).getOntologies(); |
Contributor
There was a problem hiding this comment.
Note this way you change the meaning of catalogPath == null from "dont use catalog" to "use default". I dont think this will pass the @jamesaoverton QC guard.
| * @param catalogPath path to the explicit catalog, or null | ||
| */ | ||
| InputOntologies(String catalogPath) { | ||
| this.catalogPath = catalogPath; |
Contributor
There was a problem hiding this comment.
At least if I read the code correctly, you dont need the catalogPath in the object, and least not right now. The methods that are calling the class object already have the catalog available. just saying. :P
| for (File inputOntologyFile : getFilesByPattern(pattern)) { | ||
| inputOntologies.add(ioHelper.loadOntology(inputOntologyFile, true, inputFormat)); | ||
| OWLOntology ontology; | ||
| if (catalogFile != null) { |
Contributor
There was a problem hiding this comment.
Somehow this if else seems like it could be refactored to fit both 1160ff and this instance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/have been added/updatedmvn verifysays all tests passmvn sitesays all JavaDocs correctCHANGELOG.mdhas been updatedFixes #1250.