Skip to content

Lazy warnings about unsupported han #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: tf-1.x
Choose a base branch
from
Open

Lazy warnings about unsupported han #769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions onnx_tf/backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,8 @@ def _onnx_node_to_tensorflow_op(cls,
if handlers:
handler = handlers[node.domain].get(node.op_type, None) if node.domain in handlers else None
if handler:
if hasattr(handler, "WARNINGS"):
common.logger.warning(handler.WARNINGS)
return handler.handle(node, tensor_dict=tensor_dict, strict=strict)

raise BackendIsNotSupposedToImplementIt("{} is not implemented.".format(node.op_type))
Expand Down
6 changes: 4 additions & 2 deletions onnx_tf/common/handler_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,13 @@ def get_all_backend_handlers(opset_dict):
domain=handler.DOMAIN,
max_inclusive_version=version).since_version
except RuntimeError:
common.logger.debug("Fail to get since_version of {} in domain `{}` "
handler.WARNINGS = (((handler.WARNINGS + "\n") if hasattr(handler, "WARNINGS") else "") +
"Fail to get since_version of {} in domain `{}` "
"with max_inclusive_version={}. Set to 1.".format(
handler.ONNX_OP, handler.DOMAIN, version))
else:
common.logger.debug("Unknown op {} in domain `{}`.".format(
handler.WARNINGS = (((handler.WARNINGS + "\n") if hasattr(handler, "WARNINGS") else "") +
"Unknown op {} in domain `{}`.".format(
handler.ONNX_OP, handler.DOMAIN or "ai.onnx"))
handler.SINCE_VERSION = since_version
handlers.setdefault(domain, {})[handler.ONNX_OP] = handler
Expand Down