Skip to content

Add hover scroll by keyboard #3804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add hover scroll by keyboard #3804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Feature/LanguageSupport/Feature_LanguageSupport.re
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,10 @@ module Msg = {
module Hover = {
let show = Hover(Hover.(Command(Show)));

let scrollDown = Hover(Hover.(Command(ScrollDown)));

let scrollDown = Hover(Hover.(Command(ScrollUp)));

let mouseHovered = location => Hover(Hover.MouseHovered(location));
let mouseMoved = location => Hover(Hover.MouseMoved(location));

Expand Down
25 changes: 23 additions & 2 deletions src/Feature/LanguageSupport/Hover.re
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,9 @@ module IDGenerator =

[@deriving show({with_path: false})]
type command =
| Show;
| Show
| ScrollDown
| ScrollUp;

[@deriving show({with_path: false})]
type msg =
Expand Down Expand Up @@ -140,6 +142,8 @@ let update =
msg,
) =>
switch (msg) {
| Command(ScrollDown)
| Command(ScrollUp)
| Command(Show) =>
switch (maybeBuffer) {
| Some(buffer) =>
Expand Down Expand Up @@ -280,10 +284,27 @@ module Commands = {
"editor.action.showHover",
Command(Show),
);

let scrollDown =
define(
~category="Hover",
~title="Scroll down",
"editor.action.scrollHoverDown",
Command(ScrollDown)
)


let scrollUp =
define(
~category="Hover",
~title="Scroll up",
"editor.action.scrollHoverUp",
Command(ScrollUp)
)
};

module Contributions = {
let commands = Commands.[show];
let commands = Commands.[show, scrollDown, scrollUp];
};

module Styles = {
Expand Down