Hexadecimal integer literals get corrupted

[gunnark-ab]

Describe the bug

When returning 0x1 cast to Int from a Script, the Playground shows the result value as 5.

When Cadence code contains a hexadecimal integer literal like 0x1, it gets corrupted and evaluates to the number + 4 (number of accounts).

To Reproduce
Steps to reproduce the behavior:

1. Run pub fun main(): Int { return 0x1 } as a script
2. The returned result is:

{"value":"5","type":"Int"}

Expected behavior

• The result should be:

  {"value":"1","type":"Int"}

• Hexadecimal integer literals do not get corrupted

Screenshots

Environment

• OS: macOS Big Sur, 11.6.6
• Browser: Chrome, 109.0.5414.119 (Official Build) (x86_64)

Reason

Address replacement logic in

flow-playground-api/adapter/address.go

Lines 50 to 70 in f4b28c1

	func contentAdapter(input string, fromInput bool) string {
	r := regexp.MustCompile(`0x0*(\d+)`)
	// we must use this logic since if we parse the address to Address type
	// it outputs it in standard format which might be different to the input format
	for _, addressMatch := range r.FindAllStringSubmatch(input, -1) {
	original := addressMatch[0]
	addr, _ := strconv.Atoi(addressMatch[1])
	if fromInput {
	addr = addr + numberOfServiceAccounts
	} else if addr > numberOfServiceAccounts { // don't convert if service address, shouldn't happen
	addr = addr - numberOfServiceAccounts
	}
	replaced := strings.ReplaceAll(original, addressMatch[1], fmt.Sprintf("%d", addr))
	input = strings.ReplaceAll(input, original, replaced)
	}
	return input
	}

should only apply to imports, not integer literals

[turbolent]

Related:

• Expose bootstrapping options with fvm flow-go#2812
• Address replace bug #125

[devbugging]

@DylanTinianov can you take a look at this, it probably is coming form the address adapters.

[DylanTinianov]

@DylanTinianov can you take a look at this, it probably is coming form the address adapters.

I'll look into this asap.

[turbolent]

Happy to help here. Is the address adjustment logic trying to only adjust addresses in imports, or any address in the code?

import 0x1 // address in import

pub fun main(): Address {
    let number = 0x1 // integer literal, not an address

    return 0x1 // address value
}

[devbugging]

The translation happens here https://github.com/onflow/flow-playground-api/blob/master/adapter/address.go
If I remember correctly it should do that in many different places. Probably there is a miss tho.

[DylanTinianov]

Currently this is an edge case we don’t plan on supporting in this version of Playground, but will be fixed in Playground v2. Sorry for any inconvenience this has caused!

[bluesign]

@DylanTinianov If v1 has some more time to live, I can make a quick PR to emulator to skip N addresses when bootstrapping. ( we can use it only with simple addresses and not effect normal users )