Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new import syntax #208

Closed
Tracked by #241
DylanTinianov opened this issue Feb 17, 2023 · 2 comments
Closed
Tracked by #241

Support new import syntax #208

DylanTinianov opened this issue Feb 17, 2023 · 2 comments
Assignees
Labels
feature A new user feature or a new package API

Comments

@DylanTinianov
Copy link
Contributor

DylanTinianov commented Feb 17, 2023

Is your feature request related to a problem? Please describe.
Playground v2 should not have to deal with address translation. Currently on v1, there is an issue in address translation where all hexadecimal values are translated (regardless of being an import or not).

Solution
The best solution for this is to only use the new import syntax in v2 and have no address translation at all.

  • The frontend should show accounts as names rather than addresses
  • Maintain a flow.json file to resolve imports rather than translating
  • Use flowkit for supporting the new import syntax

This will also allow for a smoother transition from Playground to local development as the flow.json file would also be exported and so imports will work the same.

Fixes this issue for v2: #201

@DylanTinianov DylanTinianov added bug Something isn't working Epic v2 labels Feb 17, 2023
@DylanTinianov DylanTinianov self-assigned this Feb 17, 2023
@DylanTinianov DylanTinianov moved this to 🔖 Ready for Pickup in 🌊 Flow 4D Feb 17, 2023
@bluesign
Copy link
Contributor

bluesign commented Feb 18, 2023

Problem is; it is not only imports. getAccount(0x2) still needs translation, likewise for example if script is getting an Address parameter.

I think getting rid of the translation will be needed eventually.

@devbugging
Copy link
Contributor

@bluesign we can still show addresses for each account but they won't be as important (beside few edge cases which you mention). This is not just about translation but also about making the playground experience more similar to local.

@DylanTinianov DylanTinianov changed the title Only support new import syntax Support new import syntax Apr 5, 2023
@devbugging devbugging removed the bug Something isn't working label Apr 13, 2023
@DylanTinianov DylanTinianov added feature A new user feature or a new package API and removed v2 Epic labels May 11, 2023
@DylanTinianov DylanTinianov moved this from 🔖 Ready for Pickup to 🏗 In progress in 🌊 Flow 4D Jun 20, 2023
@DylanTinianov DylanTinianov moved this from 🏗 In progress to 👀 In review in 🌊 Flow 4D Jul 10, 2023
@DylanTinianov DylanTinianov moved this from 👀 In review to ✅ Done in 🌊 Flow 4D Jul 10, 2023
@DylanTinianov DylanTinianov moved this from ✅ Done to 🎉 Released in 🌊 Flow 4D Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new user feature or a new package API
Projects
None yet
Development

No branches or pull requests

3 participants