Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Changed max subscription error code to 429 #7158

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Guitarheroua
Copy link
Contributor

In this PR the error code for max subscriptions reached was changed from 503 to 429, as this is not a server error, but more server limitation.

See context here

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 41.24%. Comparing base (89dfb91) to head (56a5991).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
engine/access/rest/websockets/controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7158   +/-   ##
=======================================
  Coverage   41.24%   41.24%           
=======================================
  Files        2171     2170    -1     
  Lines      190061   190028   -33     
=======================================
- Hits        78391    78384    -7     
+ Misses     105127   105103   -24     
+ Partials     6543     6541    -2     
Flag Coverage Δ
unittests 41.24% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@peterargue peterargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a test case that covers this? If not we should add one.

@illia-malachyn
Copy link
Contributor

is there a test case that covers this? If not we should add one.

Yes, there is. I updated the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants