-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Malleability] Update herocache to use generics and implement BackData. #7151
base: 6646-mempool-refactoring
Are you sure you want to change the base?
[Malleability] Update herocache to use generics and implement BackData. #7151
Conversation
…unctions with generics args
…into andron/7074-update-herocache-to-implement-BackData
@jordanschalm Hi, I want to ask for your advice. I added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First batch of comments. Overall all good, can you make sure that Tracer
is properly integrated, also can you run lint and ensure tests are passing?
…into andron/7074-update-herocache-to-implement-BackData
Both cache and pool tests are passing. Fixed |
Context
In this PR Cache and PoolEntity were refactored to use generics enabling them to handle any data type for both the key and the value.
As Cache going to work with
flow.Identifier
so onlyV
was introduced there.PoolEntity now uses generic type parameters:
This PR is part of the broader refactoring effort referenced in EPIC #6646.
Closes: #7074.