[Access] Refactor access subscriptions #7105
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterargue
commented
Feb 28, 2025
| @@ -1569,3 +1569,20 @@ func checkBlockStatus(blockStatus flow.BlockStatus) error { | |||
| } | |||
| return nil | |||
| } | |||
|
|
|||
| // HandleRPCSubscription is a generic handler for subscriptions to a specific type for rpc calls. | |||
There was a problem hiding this comment.
this is now duplicated in 2 places since the logic is very simple.
zhangchiqing
approved these changes
Feb 28, 2025
janezpodhostnik
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 4 of a series of PRs to refactor common code with
/accessinto separate modules. The goal is to remove cyclical imports resulting from too many common structs being defined in one place.This PR moves the subscription trackers into their own module since they were the only things with dependencies to
engine/access/rpc. This causes cyclical imports when putting code in/accessthat's referenced in various RPC modules.