Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Refactor validator into own module #7102

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

peterargue
Copy link
Contributor

@peterargue peterargue commented Feb 28, 2025

Issue #7111:
This is part 1 of a series of PRs to refactor common code with /access into separate modules. The goal is to remove cyclical imports resulting from too many common structs being defined in one place.

This PR moves the access.TransactionValidator to its own module.

@peterargue peterargue requested a review from a team as a code owner February 28, 2025 03:23
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.

Project coverage is 41.28%. Comparing base (82d7f1d) to head (ff1300e).

Files with missing lines Patch % Lines
cmd/access/node_builder/access_node_builder.go 0.00% 3 Missing ⚠️
integration/internal/emulator/errors.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7102      +/-   ##
==========================================
+ Coverage   41.25%   41.28%   +0.03%     
==========================================
  Files        2170     2171       +1     
  Lines      190050   190050              
==========================================
+ Hits        78409    78470      +61     
+ Misses     105097   105011      -86     
- Partials     6544     6569      +25     
Flag Coverage Δ
unittests 41.28% <81.81%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@Guitarheroua Guitarheroua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants