[Storage] Refactor computation result status storage #7084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7084 +/- ##
==========================================
+ Coverage 41.23% 41.25% +0.02%
==========================================
Files 2155 2155
Lines 189329 189323 -6
==========================================
+ Hits 78067 78111 +44
+ Misses 104760 104700 -60
- Partials 6502 6512 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
23 tasks
zhangchiqing
requested review from
fxamacker,
janezpodhostnik and
peterargue
peterargue
approved these changes
Feb 27, 2025
| @@ -82,7 +82,6 @@ const ( | |||
| // code for ComputationResult upload status storage | |||
| // NOTE: for now only GCP uploader is supported. When other uploader (AWS e.g.) needs to | |||
| // be supported, we will need to define new code. | |||
| codeComputationResults = 66 | |||
There was a problem hiding this comment.
should this be deprecated instead of removed?
There was a problem hiding this comment.
This is now an unused variable after the refactor. The same variable is now defined in storage/operation/prefix.go , that's why I had to remove it.
peterargue
reviewed
Feb 27, 2025
| @@ -82,7 +82,6 @@ const ( | |||
| // code for ComputationResult upload status storage | |||
| // NOTE: for now only GCP uploader is supported. When other uploader (AWS e.g.) needs to | |||
| // be supported, we will need to define new code. | |||
| codeComputationResults = 66 | |||
There was a problem hiding this comment.
how about
_ = 66 // used by ComputationResults in storage/operation
janezpodhostnik
approved these changes
Mar 4, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 5, 2025
…status-storage [Storage] Refactor computation result status storage
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working towards #6515
Refactor computation result status storage