Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage Refactor] Using flags to roll out database operation changes for Verification nodes. #6948

Merged
merged 9 commits into from
Mar 5, 2025

Conversation

zhangchiqing
Copy link
Member

@zhangchiqing zhangchiqing commented Jan 28, 2025

Depend on:

Working towards: #6515

This PR adds flags to all node type for switching database operations, as well as switching from badger to pebble for verification node storing all verification specific data, such as approvals and chunk locators.

@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 4.25532% with 45 lines in your changes missing coverage. Please review.

Project coverage is 41.23%. Comparing base (08fd825) to head (45699d4).

Files with missing lines Patch % Lines
cmd/verification_builder.go 0.00% 18 Missing ⚠️
cmd/scaffold.go 0.00% 17 Missing ⚠️
storage/dbops/dbops.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6948      +/-   ##
==========================================
+ Coverage   41.21%   41.23%   +0.01%     
==========================================
  Files        2154     2155       +1     
  Lines      189297   189329      +32     
==========================================
+ Hits        78022    78066      +44     
+ Misses     104766   104762       -4     
+ Partials     6509     6501       -8     
Flag Coverage Δ
unittests 41.23% <4.25%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhangchiqing zhangchiqing changed the base branch from master to leo/storage-refactor-chunk-locators February 10, 2025 19:01
@zhangchiqing zhangchiqing force-pushed the leo/verification-flags-badger-updates branch 2 times, most recently from f00c40a to d4cb27f Compare February 10, 2025 19:26
Base automatically changed from leo/storage-refactor-chunk-locators to master February 25, 2025 22:44
@zhangchiqing zhangchiqing force-pushed the leo/verification-flags-badger-updates branch from d4cb27f to 81c081c Compare February 26, 2025 00:24
@zhangchiqing zhangchiqing force-pushed the leo/verification-flags-badger-updates branch from 611e9ee to 31e0dbd Compare February 28, 2025 19:32
@zhangchiqing zhangchiqing marked this pull request as ready for review March 3, 2025 22:32
@zhangchiqing zhangchiqing requested a review from a team as a code owner March 3, 2025 22:32
@zhangchiqing zhangchiqing added this pull request to the merge queue Mar 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 4, 2025
@zhangchiqing zhangchiqing added this pull request to the merge queue Mar 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 4, 2025
@zhangchiqing zhangchiqing added this pull request to the merge queue Mar 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 4, 2025
@zhangchiqing zhangchiqing enabled auto-merge March 5, 2025 00:54
@zhangchiqing zhangchiqing added this pull request to the merge queue Mar 5, 2025
Merged via the queue into master with commit 7ea8eb7 Mar 5, 2025
56 checks passed
@zhangchiqing zhangchiqing deleted the leo/verification-flags-badger-updates branch March 5, 2025 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants