Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builder perks #1172

Merged
merged 8 commits into from
Mar 14, 2025
Merged

Builder perks #1172

merged 8 commits into from
Mar 14, 2025

Conversation

Aliserag
Copy link
Contributor

@Aliserag Aliserag commented Mar 7, 2025

Added builder perks page with initial 4 perks partners and checks to see if they have connected their wallet or completed their profile. This will act as an additional incentive for fully completing profiles and minimize abuse.

Copy link

vercel bot commented Mar 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2025 2:25pm

Copy link
Contributor

@briandoyle81 briandoyle81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great overall, but I can't create a profile on testnet successfully to test the success case.

I think this should use actionCard and actionCard grid instead of creating new components.

You should be able to add the icons to useIcons, though the Icons component might need some tweaking to not try and assign colors to them.

Need to update the icon component as the format of the svgs ingested in the homepage are different from the logo images, so making the icon component more versatile allowing it to accept string paths for rendering react images.
Copy link
Contributor

@briandoyle81 briandoyle81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cards look great!

Please iterate on the styling for the modal popups, they look a little raw. Cursor etc. are great at helping with this.

The button for if your profile isn't complete just dumps you to the home page and could also use some styling love please and thanks!

Copy link
Contributor

@briandoyle81 briandoyle81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@Aliserag Aliserag merged commit 9d80621 into main Mar 14, 2025
3 checks passed
@Aliserag Aliserag deleted the builder-perks branch March 14, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants