-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Builder perks #1172
Builder perks #1172
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great overall, but I can't create a profile on testnet successfully to test the success case.
I think this should use actionCard and actionCard grid instead of creating new components.
You should be able to add the icons to useIcons, though the Icons component might need some tweaking to not try and assign colors to them.
Need to update the icon component as the format of the svgs ingested in the homepage are different from the logo images, so making the icon component more versatile allowing it to accept string paths for rendering react images.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cards look great!
Please iterate on the styling for the modal popups, they look a little raw. Cursor etc. are great at helping with this.
The button for if your profile isn't complete just dumps you to the home page and could also use some styling love please and thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Added builder perks page with initial 4 perks partners and checks to see if they have connected their wallet or completed their profile. This will act as an additional incentive for fully completing profiles and minimize abuse.