Skip to content

[Compiler] Decouple value.Transfer method from the interpreter #3819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 1, 2025

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented Mar 22, 2025

Work towards #3693

Depends on #3817, #3820

Description

Change the first parameter of interpreter.Value.Transfer() method from interpreter *Interpreter, to ValueTransferContext.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@SupunS SupunS mentioned this pull request Mar 24, 2025
6 tasks
@SupunS SupunS changed the base branch from supun/refactor-vm-values to supun/sync-with-master March 24, 2025 15:11
@SupunS SupunS marked this pull request as ready for review March 26, 2025 00:29
@SupunS SupunS requested a review from turbolent as a code owner March 26, 2025 00:29
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Base automatically changed from supun/sync-with-master to feature/compiler April 1, 2025 18:52
Copy link

github-actions bot commented Apr 1, 2025

Cadence Benchstat comparison

This branch with compared with the base branch onflow:feature/compiler commit 6dad792
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

@SupunS SupunS merged commit 5b927bf into feature/compiler Apr 1, 2025
7 of 9 checks passed
@SupunS SupunS deleted the supun/refactor-values-2 branch April 1, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants