[DO NOT MERGE] Bump atree version to use updated branch of fxamacker/cbor #3818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, atree is using a feature branch of fxamacker/cbor that was based on cbor v2.4.0. This commit bumps version of fxamacker/cbor to use the updated feature/stream-mode branch based on fxamacker/cbor v2.7.0.
fxamacker
force-pushed
the
fxamacker/bump-atree-version-to-use-updated-cbor-branch
branch
from
749d9e7 to
1f1659d
Compare
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:v1.3 commit 6d0a2c9 Collapsed results for better readability
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, atree is using a feature branch of fxamacker/cbor that was based on cbor v2.4.0.
Anchorage Digital has dependencies requiring fxamacker/cbor v2.7.0, so they were encountering build error because atree and cadence were using fxamacker/cbor branch based on v2.4.0.
This PR bumps versions to use the updated feature/stream-mode branch of fxamacker/cbor that is backward compatible with v2.7.0 while also having extra CBOR streaming features we use.
masterbranchFiles changedin the Github PR explorer