Skip to content

Conversation

@fxamacker
Copy link
Member

@fxamacker fxamacker commented Oct 24, 2025

Updates onflow/flow-go#8042

Added more guidelines:

Before submitting a security report, please review your source code included in the report. For example, please check if function calls return any errors and avoid calling functions on a nil object.

Even if the bug report relied on an obvious mistake made by the team submitting the report, it still takes time to review the other content, just in case it includes a real bug.


  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Added: "Before submitting a security report, please review your source code included in the report. For example, please check if function calls return any errors and avoid calling a function on a `nil` object."
@fxamacker fxamacker self-assigned this Oct 24, 2025
@fxamacker fxamacker requested a review from turbolent as a code owner October 24, 2025 15:41
@fxamacker fxamacker added the documentation Improvements or additions to documentation label Oct 24, 2025
@fxamacker
Copy link
Member Author

@turbolent PTAL 🙏

If security reports contain obvious bugs that can be spotted at a quick glance, then I think there is a chance that some reviewer in the future might not examine the report's other content as thoroughly as they should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants