style: autofix "ALL" ruff rules + S110 #671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """If `content` is Python/REPL code, return instructions on using code blocks.""" | ||
| log.trace("Creating instructions for a missing code block.") | ||
|
|
||
| if _parsing.is_python_code(content): |
There was a problem hiding this comment.
might be out of scope but this method should be inverted. Check for not python code and then log and return.
There was a problem hiding this comment.
Hmm, I don't see a line enabling ALL rules?
There was a problem hiding this comment.
I locally set it, ran stable fixes, and then reverted. The repo obviously doesn't pass ALL out of the bot. I planned to break it out into stable / easy fixes and then slowly provide the opinionated - not automatic - fixes.
These are only fixes from stable auto fixes. Many errors still remain before ALL rules can be enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR first re-enables S110. And then I locally set the rules to "ALL" and autofixed rules.
You will notice that "COM" is ignored even though it isn't enabled. This is preemptive, but
COMhas conflicts with other format rules and IMO should be disabled from the ALL list.Note
This PR was pretty easy to make. So don't feel bad if you disagree with my direction and want to shut this down.
I have checked all the changes, and they all seem logical to me.