refactor: use components v2 and modals for managing configuration options #660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
left to do: add listeners/views for processing the received objects |
onerandomusername
force-pushed
the
qt/revamped-config
branch
from
27be3ff to
4f303ab
Compare
onerandomusername
force-pushed
the
qt/revamped-config
branch
from
6da953c to
bac95db
Compare
|
left to do: de-dupe code, potentially support config options which have a list of potential options, which need to be their own selects |
|
Will support enum options later. While important, this isn't necessary at this moment in time, as no configuration options need enum support. |
Issues attributed to commits in this pull requestThis pull request was merged and Sentry observed the following issues:
|
This is a separate issue regarding slow startups of the bot. It doesn't have anything to do with this pull. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #659