Build dockers #1298
Build dockers #1298
Conversation
|
@lukaszstolarczuk |
rbanka1
force-pushed
the
newDocker
branch
2 times, most recently
from
6039c67 to
b1d2ec2
Compare
rbanka1
force-pushed
the
newDocker
branch
5 times, most recently
from
3552ecc to
aefd38a
Compare
.github/workflows/pr_push.yml
Outdated
|
|
||
| jobs: | ||
| CodeChecks: | ||
| uses: ./.github/workflows/reusable_checks.yml | ||
| FastBuild: | ||
| name: Fast builds |
There was a problem hiding this comment.
why the name was removed?
.github/workflows/detect_changes.yml
Outdated
| run: | | ||
| echo "Changed files: $ALL_CHANGED_FILES" | ||
|
|
||
| RunReusableDocker: |
There was a problem hiding this comment.
perhaps simply BuildDocker
.github/workflows/reusable_basic.yml
Outdated
| strategy: | ||
| matrix: | ||
| os: ['ubuntu-22.04', 'ubuntu-24.04'] | ||
| ubuntu_ver: ['ubuntu-22.04', 'ubuntu-24.04'] |
There was a problem hiding this comment.
we should probably go back to the os name, as it contains not only the ubu ver
.github/workflows/reusable_basic.yml
Outdated
| - name: Install g++-7 | ||
| if: matrix.compiler.cxx == 'g++-7' | ||
| run: sudo apt-get install -y ${{matrix.compiler.cxx}} | ||
| echo "${USERPASS}" | sudo -Sk bash -c " |
There was a problem hiding this comment.
some as above, perhaps sudo su
There was a problem hiding this comment.
I wrote installation script to avoid multi-line bash command
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| ubuntu-version: [20.04, 22.04, 24.04] |
There was a problem hiding this comment.
I believe for unity, this should also be os (full name of the distro)
.github/workflows/reusable_fast.yml
Outdated
| strategy: | ||
| matrix: | ||
| include: | ||
| - os: windows-latest | ||
| - ubuntu_ver: ubuntu-22.04 |
There was a problem hiding this comment.
same - re-name to os please
.github/workflows/reusable_basic.yml
Outdated
| ${{ matrix.install_tbb == 'ON' && matrix.disable_hwloc != 'ON' && matrix.shared_library == 'ON' && '--proxy' || '' }} | ||
| --umf-version ${{env.UMF_VERSION}} | ||
| ${{ matrix.shared_library == 'ON' && '--shared-library' || '' }} | ||
| # - name: Test UMF installation and uninstallation |
There was a problem hiding this comment.
and I believe it's the time to uncomment this - what's failing with that? please send me a link and we'll investigate...
There was a problem hiding this comment.
not necessary, it is working :)
rbanka1
force-pushed
the
newDocker
branch
4 times, most recently
from
f15cda9 to
5705c2a
Compare
I added a new Docker image for Ubuntu 24.04 and updated the others. I also created two new workflows that check for changes in the Docker files. If any changes are detected, the relevant Docker image will be rebuilt and pushed (unless it's a pull request). The rebuilt images will be available after the merge.
Added UMF docker
This is the first part only for docker build. The second with updated CI : #1329
// workflow executed on fork:
https://github.com/rbanka1/unified-memory-framework/actions/runs/15134054789
https://github.com/rbanka1/unified-memory-framework/actions/runs/15134054814
I added a new Docker image for Ubuntu 24.04 and updated the others.
I also created two new workflows that check for changes in the Docker files.
If any changes are detected, the relevant Docker image will be rebuilt and pushed (unless it's a pull request).
The rebuilt images will be available after the merge.