Fix UMF build on Alpine OS #1294
Open
+98
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lplewa
reviewed
May 5, 2025
src/utils/utils_log.c
Outdated
Comment on lines
157
to
158
| #if (_POSIX_C_SOURCE >= 200112L || _XOPEN_SOURCE >= 600) && !_GNU_SOURCE | ||
| char err[1024]; | ||
| int err_ret = strerror_r(saveno, err, sizeof(err)); | ||
| if (err_ret == ERANGE) { | ||
| postfix = "[truncated...]"; | ||
| } | ||
| #else |
There was a problem hiding this comment.
is it different from the apple version? can you just update apple ifdef?
wlemkows
force-pushed
the
alpine-umf
branch
7 times, most recently
from
28f0fe7 to
7e6224d
Compare
.github/workflows/reusable_trivy.yml
Outdated
| @@ -19,13 +19,20 @@ jobs: | |||
| with: | |||
| fetch-depth: 0 | |||
|
|
|||
| - name: Manual Trivy Setup | |||
| uses: aquasecurity/setup-trivy@9ea583eb67910444b1f64abf338bd2e105a0a93d | |||
There was a problem hiding this comment.
pls add a comment which version of the action is it (e.g. similarly to the one below: # v0.30.0)
There was a problem hiding this comment.
It appears that we are now using the correct version by default, and I no longer see the error in the logs; therefore, I decided to remove the manual setup.
.github/workflows/reusable_trivy.yml
Outdated
| @@ -19,13 +19,20 @@ jobs: | |||
| with: | |||
| fetch-depth: 0 | |||
|
|
|||
| - name: Manual Trivy Setup | |||
There was a problem hiding this comment.
you could add a simple comment why to set it up manually
There was a problem hiding this comment.
It appears that we are now using the correct version by default, and I no longer see the error in the logs; therefore, I decided to remove the manual setup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist