Skip to content

do basic CI code checks in the docker #1250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bratpiorka
Copy link
Contributor

@bratpiorka bratpiorka commented Apr 10, 2025

do basic CI code checks in the docker

@bratpiorka bratpiorka force-pushed the rrudnick_self_host_pr_push branch 30 times, most recently from 145ee34 to e4c6556 Compare April 11, 2025 09:06
@bratpiorka bratpiorka force-pushed the rrudnick_self_host_pr_push branch 24 times, most recently from 0583049 to 0851cfb Compare April 14, 2025 07:57
@bratpiorka bratpiorka changed the title [WIP] move pr_push jobs to self-hosted runner do basic CI code checks in the docker Apr 14, 2025
@bratpiorka bratpiorka marked this pull request as ready for review April 14, 2025 08:22
@bratpiorka bratpiorka requested a review from a team as a code owner April 14, 2025 08:22
@@ -55,6 +59,7 @@ RUN mkdir --mode 777 /opt/umf/
# Additional dependencies (installed via pip)
COPY third_party/requirements.txt /opt/umf/requirements.txt
RUN pip3 install --no-cache-dir -r /opt/umf/requirements.txt
RUN pip3 install bandit codespell
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this is not in requirements?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lukaszstolarczuk could you help here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done: #1276

@bratpiorka bratpiorka marked this pull request as draft April 18, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants