Add sycl benchmark to sycl compatibility workflow #1226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatKamin
force-pushed
the
sycl-bench-compat
branch
4 times, most recently
from
3fce69a to
a6cfee8
Compare
bratpiorka
reviewed
Mar 31, 2025
.github/workflows/reusable_sycl.yml
Outdated
| @@ -120,3 +122,24 @@ jobs: | |||
| echo "---Run build_log test" && ./build_log | |||
| echo "---Run parallel_for_range_roundup test" && ./parallel_for_range_roundup | |||
| echo "---Run fill_any_size test" && ./fill_any_size | |||
|
|
|||
| # Run sycl benchmarks | |||
There was a problem hiding this comment.
run this on benchmark machine
There was a problem hiding this comment.
Done, extended the Nightly benchmark job instead
PatKamin
force-pushed
the
sycl-bench-compat
branch
6 times, most recently
from
a5b9f79 to
59b2003
Compare
bratpiorka
reviewed
Apr 1, 2025
| run_sycl: | ||
| required: false | ||
| type: boolean | ||
| default: false |
There was a problem hiding this comment.
As to run it only during the Nightly job. However, now I see that there is an advantage of running these always, also on the workflow_dispatch by hand - I'll remove this condition.
| @@ -162,6 +186,8 @@ jobs: | |||
| --results-dir ${{ github.workspace }}/results-repo | |||
| --output-markdown | |||
| ${{ env.bench_params }} | |||
| ${{ inputs.run_sycl && '--sycl env.SYCL_DIR' || '' }} | |||
| ${{ inputs.run_sycl && '--adapter level_zero' || '' }} | |||
PatKamin
force-pushed
the
sycl-bench-compat
branch
15 times, most recently
from
fa7decb to
b307fc0
Compare
PatKamin
force-pushed
the
sycl-bench-compat
branch
3 times, most recently
from
7077fb3 to
b9c6020
Compare
PatKamin
force-pushed
the
sycl-bench-compat
branch
from
b9c6020 to
291c6ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a sycl benchmark script run as an additional sycl compatibility test
Checklist