Repository navigation
Please use (void) and not () #342
Description
For example in:
https://github.com/oneapi-src/level-zero/blob/de1e9f42641cf7513672c2f3a5c306034a4f7e96/include/loader/ze_loader.h#L97C16-L97C46
I suppose here you mean no parameter, not unknow number of parameters.
The other are
h2yaml diagnostic: modified_include/loader/ze_loader.h:71:1: Warning: `zelSetDriverTeardown` defines a function with no parameters, consider specifying `void`.
h2yaml diagnostic: modified_include/loader/ze_loader.h:77:1: Warning: `zelSetDelayLoaderContextTeardown` defines a function with no parameters, consider specifying `void`.
h2yaml diagnostic: modified_include/loader/ze_loader.h:83:1: Warning: `zelLoaderContextTeardown` defines a function with no parameters, consider specifying `void`.
h2yaml diagnostic: modified_include/loader/ze_loader.h:89:1: Warning: `zelEnableTracingLayer` defines a function with no parameters, consider specifying `void`.
h2yaml diagnostic: modified_include/loader/ze_loader.h:95:1: Warning: `zelCheckIsLoaderInTearDown` defines a function with no parameters, consider specifying `void`.
h2yaml diagnostic: modified_include/loader/ze_loader.h:136:1: Warning: `zelDisableTracingLayer` defines a function with no parameters, consider specifying `void`.
Activity
eero-t commentedon May 7, 2026
For C++
()has always meant(void), wheres the latest C23 standard finally applied same interpretation for C (requires-std=c23option for GCC/Clang/LLVM).The indicated APIs are all in the API tracing layer
ze_loader.hAPI header. Its users inside this project are all C++ code, so these APIs are interpreted correctly for them.But I do do agree that that this trivial fix should be done as it's a C-API for header included to
level-zero-develpackage, and LTS distros haven't enabled C23 for compilers yet.It's rather low impact though, as it's quite unlikely that there are:
TApplencourt commentedon May 7, 2026
Agree. Pretty low impact, just a simple "beauty" fix.
Concerning your two points:
You have one: me ! 😄 (via https://github.com/argonne-lcf/THAPI/). But you are right, we don't trigger your third point.
eero-t commentedon May 7, 2026
Thanks, that looks interesting project! As you're supporting many different APIs, I guess
-std=c23is out of question, at least currently.(I'm not loader maintainer, just another user of L0 APIs.)
TApplencourt commentedon May 8, 2026
:D Their is dozen of us. Dozen!
rwmcguir commentedon Jul 15, 2026
@TApplencourt Please take a look at the attached review and see if this resolves your issue.
TApplencourt commentedon Jul 16, 2026
Thanks a lot!