Add test cases for zeCommandListAppendLaunchCooperativeKernel with SVM #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
|
Convert to draft if in progress |
Signed-off-by: Misiak, Konstanty <[email protected]>
Signed-off-by: Misiak, Konstanty <[email protected]>
Signed-off-by: Misiak, Konstanty <[email protected]>
KonstantyMisiak
force-pushed
the
cooperative_kernel_Svm
branch
from
83c29a3 to
80844dc
Compare
gwawiork
suggested changes
Sep 1, 2025
| @@ -24,6 +24,7 @@ add_lzt_test( | |||
| level_zero_tests::random | |||
| ${OS_SPECIFIC_LIBS} | |||
| KERNELS | |||
| cooperative_kernel | |||
There was a problem hiding this comment.
Update header entry to 2019-2025
|
|
||
| ze_module_handle_t module = | ||
| lzt::create_module(device, "cooperative_kernel.spv"); | ||
| const char *funcion_name = |
There was a problem hiding this comment.
Typo should be function_name
darmroz
reviewed
Sep 2, 2025
| __kernel void cooperative_kernel(__global int* input, __global int* output, const int N) { | ||
| const int gid = get_global_id(0); | ||
|
|
||
| barrier(CLK_LOCAL_MEM_FENCE | CLK_GLOBAL_MEM_FENCE); |
There was a problem hiding this comment.
Why do you use barriers in both kernels? There is no race condition in this scenario.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.