Test: Add test case to verify fan table firmware flashing #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -258,5 +258,51 @@ LZT_TEST_F( | |||
| } | |||
| } | |||
| } | |||
| LZT_TEST_F(FIRMWARE_TEST, GivenValidHandleFanTableFirmwareFlashingSuccess) { | |||
There was a problem hiding this comment.
Given ... When ... Then
naming convention has to be followed for test name
| auto firmware_handles = lzt::get_firmware_handles(device, count); | ||
| if (count == 0) { | ||
| FAIL() << "No handles found: " | ||
| << _ze_result_t(ZE_RESULT_ERROR_UNSUPPORTED_FEATURE); |
There was a problem hiding this comment.
this has to be refactored.
refer commit 7027d05
Better rebase to latest master and apply changes
sandhya-c
force-pushed
the
level_zero_tests_late_binding
branch
from
aad8c42 to
db04783
Compare
Related-To: VLCLJ-2434 Signed-off-by: kalyan alle <[email protected]>
sandhya-c
force-pushed
the
level_zero_tests_late_binding
branch
from
db04783 to
dd30f13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related-To: VLCLJ-2434