Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[External Resource Interop][Semaphores] Added support for 2 more semaphore types #2751

Open
wants to merge 1 commit into
base: SYCLomatic
Choose a base branch
from
Open

[External Resource Interop][Semaphores] Added support for 2 more semaphore types #2751

wants to merge 1 commit into from

Conversation

TejaX-Alaghari
Copy link
Contributor

This PR adds support for 2 more Semaphore types:

  • timeline_fd
  • timeline_win32_nt_handle

As well as adds all the external resource interop APIs to QAP test case

@TejaX-Alaghari TejaX-Alaghari requested a review from a team as a code owner March 28, 2025 07:09
ziranzha
ziranzha reviewed Mar 31, 2025
View reviewed changes
clang/runtime/dpct-rt/include/dpct/bindless_images.hpp
if (extSemType == sycl::ext::oneapi::experimental::
external_semaphore_handle_type::win32_nt_dx12_fence) {
q_ptr->ext_oneapi_signal_external_semaphore(
case sycl::ext::oneapi::experimental::external_semaphore_handle_type::
Copy link
Contributor

@ziranzha ziranzha Mar 31, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merge WIN32 together?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I'll refactor the switch case

ziranzha
ziranzha reviewed Mar 31, 2025
View reviewed changes
clang/lib/DPCT/RuleInfra/MapNames.cpp
@@ -1550,6 +1550,18 @@ void MapNames::setExplicitNamespaceMap(
? getExpNamespace() +
"external_semaphore_handle_type::win32_nt_dx12_fence"
: "cudaExternalSemaphoreHandleTypeD3D12Fence")},
{"cudaExternalSemaphoreHandleTypeTimelineSemaphoreFd",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the migration?

Copy link
Contributor Author

@TejaX-Alaghari TejaX-Alaghari Apr 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't understand the question

Can you please explain

@TejaX-Alaghari
Copy link
Contributor Author

The case passes locally using latest xmain-rel compiler

image

zhiweij1 pushed a commit to zhiweij1/SYCLomatic that referenced this pull request Apr 8, 2025
@YuriPlyakhin @jsji
Implement SPV_INTEL_2d_block_io (oneapi-src#2751)
118199b 
Spec: https://github.khronos.org/SPIRV-Registry/extensions/INTEL/SPV_INTEL_2d_block_io.html

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@6d6c28aa2c63c22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ziranzha ziranzha ziranzha left review comments

@tomflinda tomflinda Awaiting requested review from tomflinda tomflinda is a code owner automatically assigned from oneapi-src/syclomatic-reviewers

@ShengchenJ ShengchenJ Awaiting requested review from ShengchenJ ShengchenJ is a code owner automatically assigned from oneapi-src/syclomatic-reviewers

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TejaX-Alaghari @ziranzha