-
Notifications
You must be signed in to change notification settings - Fork 137
Remove property users from list of projects #2877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kelvin-muchiri
wants to merge
15
commits into
main
Choose a base branch
from
remove-project-list-users-forms
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+355
−225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@kelvin-muchiri, can you add a field that indicates the number of forms in a project? Also, would it be possible to check the role of the |
16189e5 to
1e9d93b
Compare
1e9d93b to
b1a09d1
Compare
users, forms makes fetching a list of projects slow. For performance optimization, this properties will only be available when a project is retrieved via endpoint /api/v1/projects/<id>
0afcc2c to
20dfccc
Compare
ukanga
approved these changes
Sep 29, 2025
ukanga
requested changes
Sep 29, 2025
ukanga
reviewed
Sep 29, 2025
Member
ukanga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update the API documentation as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
Including all users in a project from endpoint
api/v1/projectsis causing slow response times for projects that have a large number of users. In addition, it increases the size of the response, which further increases the latency.This change removes the
usersproperty in the project list endpoint and replaces it withcurrent_user_rolewhose value is the role of the request user in the project. Theusersproperty is still available on endpoint/api/v1/projects/<id>Steps taken to verify this change does what is intended
Side effects of implementing this change
Faster responses when fetching list of projects
Before submitting this PR for review, please make sure you have:
Closes #