Skip to content

Conversation

@skngetich
Copy link
Contributor

Changes / Features implemented

Updated the initial docker setup commands on the README.rst file.
The database migration step was missing and the python command stated on the README.rst file did not work since the python version was updated to python3.9 in the Dockerfile.

Steps taken to verify this change does what is intended

I cloned the repo and run docker-compose up then followed the updated steps provided in the README.rst

Side effects of implementing this change

There are no side effects

Before submitting this PR for review, please make sure you have:

  • Included tests
  • Updated documentation

Closes

@kelvin-muchiri kelvin-muchiri enabled auto-merge (squash) July 20, 2023 09:38
@kelvin-muchiri kelvin-muchiri disabled auto-merge July 20, 2023 09:39
@kelvin-muchiri
Copy link
Contributor

@skngetich Kindly rebase with the main branch

@skngetich
Copy link
Contributor Author

@kelvin-muchiri I have rebased the PR.

@kelvin-muchiri
Copy link
Contributor

@skngetich Kindly also sign your commits, it's a requirement for the PR to be merged

@skngetich
Copy link
Contributor Author

@kelvin-muchiri I have signed the commits

# Make changes(add fields and models) to the database
# -----------------
docker exec -it onadata_web_1 bash
python3.9 manage.py migration
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this need to be python3.9 manage.py migrate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants