Skip to content

Conversation

@FrankApiyo
Copy link
Member

No description provided.

@FrankApiyo FrankApiyo force-pushed the ona-custom-changes branch 2 times, most recently from 2187ba4 to b740c9d Compare December 14, 2022 06:31
@FrankApiyo FrankApiyo force-pushed the ona-custom-changes branch 3 times, most recently from 2bb13a6 to 0325aff Compare December 14, 2022 06:42
index.js Outdated
}
})
.catch((error) => {
console.log(error)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

index.js Outdated
} else if ("/health-check" == req.url) {
done()
} else {
done("Authentication Failure");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add a status code (401)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find how to do this from fastify documentation

index.js Outdated
.then(fastify => // LAUNCH SERVER
fastify.listen({ port: process.env.SERVER_PORT || 3000, host: process.env.SERVER_HOST || '0.0.0.0' }, (err, address) => {
if (err) {
console.log(err)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@FrankApiyo FrankApiyo force-pushed the ona-custom-changes branch from cef99bc to 8bd36bb Compare May 11, 2023 08:26
feat: Update axios version to 1.8.2
…-dataviews

Add support for merged and filtered DataViews
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants