Skip to content

Conversation

@shunsuke-h-opn
Copy link
Contributor

1. Objective

I added php-laravel example for Omise.

2. Description of change

These are what I added.

Laravel(Credit Card Charge, PayPay, Google Payment)

3. Impact of the change

None.

4. Priority of change

Normal.

@shunsuke-h-opn shunsuke-h-opn marked this pull request as ready for review November 7, 2023 07:19
@shunsuke-h-opn shunsuke-h-opn self-assigned this Nov 7, 2023
@danfowler danfowler requested a review from a team November 7, 2023 09:41
Comment on lines 21 to 23
/**
* 基本的にchargeをするときは、tokenを作って、それを元にchargeを作るものと理解してる
*/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please translate the comment into English?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, sorry.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@aashishgurung aashishgurung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove any commented codes before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants