-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: test the changes #374
base: main
Are you sure you want to change the base?
Conversation
Please check whether the issue with the CRDs (e2e GHA) is due to the registries I removed in this commit: gab-arrobo/aether-in-a-box@22a1595 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this use the shared workflow files? For testing, I think we can target the branch directly.
This PR is only for testing and never will be merged. |
@gatici @ghislainbourgeois, I think we can avoid using the DockerHub credentials by using a local registry with the help of this GitHub Action (https://docs.docker.com/build/ci/github-actions/local-registry/). What do you think? The only thing is that I am pretty certain current Helm Charts do not support different registry per NF's image. That is, all images should come from the same registry. However, this is something we can properly address in the Sdcore Hel Charts |
Hello @gab-arrobo , |
@gatici,
|
Hello Gabriel,
Here are the latest results.
|
1b3676d
to
630167e
Compare
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
8e9edc9
to
6a286d3
Compare
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to remove the following from the Dependabot file because the GHA will be managed only from omec-project/.github
repo
- - package-ecosystem: "github-actions"
- directory: "/"
- schedule:
- interval: "weekly"
- day: "sunday"
- time: "21:00"
- timezone: "America/Los_Angeles"
-
.github/workflows/main.yml
Outdated
make aether-5gc-install | ||
make aether-gnbsim-install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make aether-5gc-install | |
make aether-gnbsim-install |
.github/workflows/main.yml
Outdated
make aether-k8s-install | ||
make aether-5gc-install | ||
make aether-gnbsim-install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make aether-k8s-install | |
make aether-5gc-install | |
make aether-gnbsim-install | |
make aether-5gc-install |
.github/workflows/main.yml
Outdated
make aether-k8s-install | ||
make aether-5gc-install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make aether-k8s-install | |
make aether-5gc-install |
.github/workflows/push.yml
Outdated
branch: "rel-${{ needs.tag-github.outputs.version_branch }}" | ||
sha: '${{ github.event.pull_request.head.sha }}' | ||
uses: gatici/.github/.github/workflows/update-version.yml@add-workflows | ||
secrets: inherit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add end of line
secrets: inherit | |
secrets: inherit | |
.github/workflows/main.yml
Outdated
- name: Install aether-k8s | ||
working-directory: aether-onramp | ||
run: | | ||
make aether-k8s-install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this action is failing because the K8s cluster is not ready. If we can install a "lightweight" K8s cluster using a GHA or in another way, we could skip this step (using OnRamp to deploy K8s). What do you think?
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
This is used for testing and validating the changes in the workflows. The new E2E tests GHA is tested here.
Note:
This PR will be closed after the testing is finished.