Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use shared workflows from .github repository #374

Draft
wants to merge 38 commits into
base: main
Choose a base branch
from

Conversation

gatici
Copy link
Contributor

@gatici gatici commented Dec 19, 2024

Use shared workflows from https://github.com/omec-project/.github repository.
This PR uses existing workflows from a common repositories named .github which stores all the shared workflow templates.

Note: omec-project/.github#1 should be merged first.
Please disregard the previous conversions about E2E tests. This PR only adds the existing workflows.

@gab-arrobo
Copy link
Contributor

Please check whether the issue with the CRDs (e2e GHA) is due to the registries I removed in this commit: gab-arrobo/aether-in-a-box@22a1595

Copy link
Contributor

@ghislainbourgeois ghislainbourgeois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this use the shared workflow files? For testing, I think we can target the branch directly.

@gatici
Copy link
Contributor Author

gatici commented Dec 20, 2024

Shouldn't this use the shared workflow files? For testing, I think we can target the branch directly.

This PR is only for testing and never will be merged.

@gatici gatici marked this pull request as draft December 20, 2024 16:20
@gab-arrobo
Copy link
Contributor

@gatici @ghislainbourgeois, I think we can avoid using the DockerHub credentials by using a local registry with the help of this GitHub Action (https://docs.docker.com/build/ci/github-actions/local-registry/). What do you think? The only thing is that I am pretty certain current Helm Charts do not support different registry per NF's image. That is, all images should come from the same registry. However, this is something we can properly address in the Sdcore Hel Charts

@gatici
Copy link
Contributor Author

gatici commented Jan 7, 2025

@gatici @ghislainbourgeois, I think we can avoid using the DockerHub credentials by using a local registry with the help of this GitHub Action (https://docs.docker.com/build/ci/github-actions/local-registry/). What do you think? The only thing is that I am pretty certain current Helm Charts do not support different registry per NF's image. That is, all images should come from the same registry. However, this is something we can properly address in the Sdcore Hel Charts

Hello @gab-arrobo ,
I updated E2E tests section to use charmed-kubernetes using relevant Github action. Helm chart is deployed successfully. At the moment, UPF pod stuck in init status. Other pods become active.
I guess the following line is the reason of the problem.
https://github.com/omec-project/sdcore-helm-charts/blob/4bf08f220245f3d8384126a96b5c2ccec4f8003b/bess-upf/templates/statefulset-upf.yaml#L101
5:03
Where is the PCIDEVICE_INTEL_COM_INTEL_SRIOV_DPDK variable defined ? Could you please help on this ?
I sent you the UPF pod details through Slack.
Many thanks!

@gab-arrobo
Copy link
Contributor

@gatici,
From the e2e-test log, there is an error loading the sdcore-5g-values.yaml because of this Condition path '5g-ran-sim.enable' for chart 5g-ran-sim returned non-bool value, the value should be either true or false, but since the file is not properly passed, the variable enable: ${ENABLE_GNBSIM} (https://github.com/gab-arrobo/aether-in-a-box/blob/master/sd-core-5g-values.yaml#L361) is not getting overwritten. Therefore, it looks like the other values are not being overwritten, either. So, the default deployment mode for the UPF is DPDK and that might be the reason why your UPF pod get stuck in initialization state.

WARNING: Kubernetes configuration file is group-readable. This is insecure. Location: /home/runner/.kube/config
WARNING: Kubernetes configuration file is world-readable. This is insecure. Location: /home/runner/.kube/config
Release "sd-core" does not exist. Installing it now.
dependencies.go:63: Warning: Condition path '5g-ran-sim.enable' for chart 5g-ran-sim returned non-bool value
coalesce.go:237: warning: skipped value for kafka.config: Not a table.
Error: context deadline exceeded
make[1]: *** [Makefile:344: /home/runner/aether-in-a-box//build/milestones/5g-core] Error 1
make[1]: Leaving directory '/home/runner/aether-in-a-box'
make: *** [Makefile:118: run-aiab] Error 2
Error: Process completed with exit code 2.

@gatici
Copy link
Contributor Author

gatici commented Jan 14, 2025

@gatici, From the e2e-test log, there is an error loading the sdcore-5g-values.yaml because of this Condition path '5g-ran-sim.enable' for chart 5g-ran-sim returned non-bool value, the value should be either true or false, but since the file is not properly passed, the variable enable: ${ENABLE_GNBSIM} (https://github.com/gab-arrobo/aether-in-a-box/blob/master/sd-core-5g-values.yaml#L361) is not getting overwritten. Therefore, it looks like the other values are not being overwritten, either. So, the default deployment mode for the UPF is DPDK and that might be the reason why your UPF pod get stuck in initialization state.

WARNING: Kubernetes configuration file is group-readable. This is insecure. Location: /home/runner/.kube/config
WARNING: Kubernetes configuration file is world-readable. This is insecure. Location: /home/runner/.kube/config
Release "sd-core" does not exist. Installing it now.
dependencies.go:63: Warning: Condition path '5g-ran-sim.enable' for chart 5g-ran-sim returned non-bool value
coalesce.go:237: warning: skipped value for kafka.config: Not a table.
Error: context deadline exceeded
make[1]: *** [Makefile:344: /home/runner/aether-in-a-box//build/milestones/5g-core] Error 1
make[1]: Leaving directory '/home/runner/aether-in-a-box'
make: *** [Makefile:118: run-aiab] Error 2
Error: Process completed with exit code 2.

Hello Gabriel,
ENABLE_GNBSIM is set to true while we are running helm command. It should not create a problem.
This error happened once ( strange) but it does not appear again.
gnbsim and UPF pod does not become available.
And I am suspicious about Multus.

gatici@gaticipc:~/omec/gatici/sdcore-helm-charts$ kubectl get pod -n omec2
NAME                           READY   STATUS     RESTARTS   AGE
amf-7645cd8d75-hb482           1/1     Running    0          36m
ausf-764c8b5bc4-tcldh          1/1     Running    0          36m
gnbsim-0                       0/1     Init:0/1   0          36m
init-net-v7qxk                 1/1     Running    0          36m
kafka-0                        1/1     Running    0          36m
metricfunc-6c4885b477-ftgcm    1/1     Running    0          36m
mongodb-0                      1/1     Running    0          36m
mongodb-1                      1/1     Running    0          36m
mongodb-arbiter-0              1/1     Running    0          36m
nrf-5cbc95d9fb-9nknj           1/1     Running    0          36m
nssf-6bc6d746c-gtbrq           1/1     Running    0          36m
pcf-5856f96854-8h46l           1/1     Running    0          36m
sd-core-zookeeper-0            1/1     Running    0          36m
simapp-6887895b44-v6zbz        1/1     Running    0          36m
smf-758c87c9bf-j4h9v           1/1     Running    0          36m
udm-7dd7698685-mcrzx           1/1     Running    0          36m
udr-6d7666db5c-j5ck7           1/1     Running    0          36m
upf-0                          0/5     Init:0/1   0          36m
upf-adapter-54fc984c8f-brpwm   1/1     Running    0          36m
webui-6457c55d55-s8b5c         1/1     Running    0          36m

Here are the latest results.

gatici@gaticipc:~/omec/gabarabo/aether-in-a-box$ make 5g-test
WARNING: Kubernetes configuration file is group-readable. This is insecure. Location: /home/gatici/.kube/config
WARNING: Kubernetes configuration file is world-readable. This is insecure. Location: /home/gatici/.kube/config
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "flannel" chart repository
...Successfully got an update from the "atomix" chart repository
...Successfully got an update from the "rancher" chart repository
...Successfully got an update from the "incubator" chart repository
...Successfully got an update from the "onosproject" chart repository
...Successfully got an update from the "cord" chart repository
...Successfully got an update from the "aether" chart repository
Update Complete. ⎈Happy Helming!⎈
NODE_IP=192.168.1.117 DATA_IFACE=data RAN_SUBNET=192.168.251.0/24 ENABLE_GNBSIM=true envsubst < /home/gatici/omec/gabarabo/aether-in-a-box//sd-core-5g-values.yaml | \
helm upgrade --create-namespace --install --wait  \
        --namespace omec2 \
        --values - \
        sd-core \
        aether/sd-core --version 2.1.0
WARNING: Kubernetes configuration file is group-readable. This is insecure. Location: /home/gatici/.kube/config
WARNING: Kubernetes configuration file is world-readable. This is insecure. Location: /home/gatici/.kube/config
Release "sd-core" does not exist. Installing it now.
coalesce.go:175: warning: skipped value for kafka.config: Not a table.
Error: client rate limiter Wait returned an error: rate: Wait(n=1) would exceed context deadline
make: *** [Makefile:344: /home/gatici/omec/gabarabo/aether-in-a-box//build/milestones/5g-core] Error 1

@gatici gatici force-pushed the update-gha-for-all-branches branch 2 times, most recently from 1b3676d to 630167e Compare January 14, 2025 11:17
gatici added 18 commits March 18, 2025 15:03
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
@gatici gatici force-pushed the update-gha-for-all-branches branch from eabd6c0 to 6a286d3 Compare March 18, 2025 12:12
@gatici gatici marked this pull request as ready for review March 18, 2025 12:12
@gatici gatici force-pushed the update-gha-for-all-branches branch from 8e9edc9 to 6a286d3 Compare March 18, 2025 12:56
@gatici gatici marked this pull request as draft March 18, 2025 13:23
@gatici gatici changed the title chore: update gha in main feat: Use shared workflows Mar 18, 2025
@gatici gatici changed the title feat: Use shared workflows feat: use shared workflows .github repository Mar 18, 2025
@gatici gatici changed the title feat: use shared workflows .github repository feat: use shared workflows from .github repository Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants