Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing proj conf #32

Merged
merged 6 commits into from
May 31, 2024
Merged

Changing proj conf #32

merged 6 commits into from
May 31, 2024

Conversation

omar-abdelgawad
Copy link
Owner

📢 Describe your changes

  • 📌 changes Summary
    • Removed old configuration like setup.py, setup.cfg, requirements.txt and others for only pyproject.toml
    • Replaced pylint with Ruff.
    • Formatted and Linted entire codebase.
  • ⚠️ Breaking changes
    • None
  • 🐞 Bug Fixes:
    • None

🧪 How to test this Pull Request

  1. Delete current virtual environment and reinstall the package with pip install -e ".[dev]" in a new environment.
  2. Try pytest using pytest should take about 12 seconds.
  3. Try tox using tox should take about 288 seconds.

🗒️ Notes for future improvements

✅Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.

@omar-abdelgawad omar-abdelgawad added the enhancement New feature or request label May 31, 2024
@omar-abdelgawad omar-abdelgawad self-assigned this May 31, 2024
@eyad-hussein eyad-hussein merged commit 0e36685 into main May 31, 2024
2 checks passed
@omar-abdelgawad omar-abdelgawad deleted the changing-proj-conf branch May 31, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants