Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring interfaces #29

Merged
merged 24 commits into from
May 8, 2024
Merged

Refactoring interfaces #29

merged 24 commits into from
May 8, 2024

Conversation

omar-abdelgawad
Copy link
Owner

📢 Describe your changes

  • 📌 changes Summary
    • Changed entire structure of the package. Now we have a root img2img package.
    • Removed all redundant py.typed files.
    • updated readme,workflows,toml, setup.cfg and more.
    • Factored all of cfg, cli and dataset code into single global pacakges.
  • ⚠️ Breaking changes
    • Package layout is entirely changed. All imports were adjusted. No extra functionality though.
  • 🐞 Bug Fixes:
    • None

🧪 How to test this Pull Request

  1. the github workflow should be enough as it suggests that the package was built correctly.

🗒️ Notes for future improvements

Further changes in this branch will include having the following packages under root:

  • engine
  • models (unit, tunit, pix2pix, etc)
  • nn (convblock, resblock, etc)
  • utils

✅Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.

@omar-abdelgawad omar-abdelgawad added the enhancement New feature or request label Jan 20, 2024
@omar-abdelgawad omar-abdelgawad self-assigned this Jan 20, 2024
@omar-abdelgawad omar-abdelgawad marked this pull request as draft January 20, 2024 02:54
@omar-abdelgawad omar-abdelgawad marked this pull request as ready for review May 8, 2024 00:38
@omar-abdelgawad omar-abdelgawad merged commit 13af70a into main May 8, 2024
0 of 6 checks passed
@omar-abdelgawad omar-abdelgawad deleted the Refactoring-Interfaces branch May 8, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant