more batching to improve checkkeys latency, new memory usage metrics #987
+607
−408
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more aggressive command batching to reduce roundtrips and improve scrape duration when exporter-to-instance latency is high.
in my local tests this cuts down scrape time for ~50 check keys from 15 seconds to about
5 seconds1-2(!) secondsIt also adds the
key_memory_usage_bytes
metric which captures theMEMORY USAGE <<key>>
of a key.