Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more batching to improve checkkeys latency, new memory usage metrics #987

Merged
merged 2 commits into from
Mar 15, 2025

Conversation

oliver006
Copy link
Owner

@oliver006 oliver006 commented Mar 10, 2025

more aggressive command batching to reduce roundtrips and improve scrape duration when exporter-to-instance latency is high.

in my local tests this cuts down scrape time for ~50 check keys from 15 seconds to about 5 seconds 1-2(!) seconds

It also adds the key_memory_usage_bytes metric which captures the MEMORY USAGE <<key>> of a key.

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 68.04979% with 77 lines in your changes missing coverage. Please review.

Project coverage is 80.78%. Comparing base (9ecfaef) to head (e5bd6a6).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
exporter/keys.go 67.91% 56 Missing and 21 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #987      +/-   ##
==========================================
- Coverage   82.11%   80.78%   -1.33%     
==========================================
  Files          18       18              
  Lines        2756     2873     +117     
==========================================
+ Hits         2263     2321      +58     
- Misses        401      446      +45     
- Partials       92      106      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link

coveralls commented Mar 11, 2025

Pull Request Test Coverage Report for Build 13869298182

Details

  • 185 of 241 (76.76%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-1.0%) to 84.525%

Changes Missing Coverage Covered Lines Changed/Added Lines %
exporter/keys.go 184 240 76.67%
Files with Coverage Reduction New Missed Lines %
exporter/keys.go 4 78.46%
Totals Coverage Status
Change from base Build 13828328686: -1.0%
Covered Lines: 2436
Relevant Lines: 2882

💛 - Coveralls

@oliver006 oliver006 changed the title [wip] more batching - still needs more clean up [wip] more batching to improve checkkeys latency, new memory usage metrics Mar 11, 2025
@oliver006 oliver006 changed the title [wip] more batching to improve checkkeys latency, new memory usage metrics more batching to improve checkkeys latency, new memory usage metrics Mar 11, 2025
@oliver006 oliver006 force-pushed the oh_more_batching branch 7 times, most recently from be32eb3 to 790b28c Compare March 15, 2025 03:21
…ape duration when exporter-to-instance latency is high.
…e SCAN does not work across multiple instances
@oliver006 oliver006 merged commit 71dbe37 into master Mar 15, 2025
6 of 9 checks passed
@oliver006 oliver006 deleted the oh_more_batching branch March 15, 2025 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants