Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to skip checkKeys if role == master #985

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

oliver006
Copy link
Owner

can help with reducing load on master nodes - see #931

Copy link

codecov bot commented Mar 9, 2025

Codecov Report

Attention: Patch coverage is 69.69697% with 10 lines in your changes missing coverage. Please review.

Project coverage is 82.10%. Comparing base (7c63842) to head (aab0119).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
exporter/keys.go 64.28% 4 Missing and 1 partial ⚠️
main.go 0.00% 3 Missing ⚠️
exporter/exporter.go 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #985      +/-   ##
==========================================
- Coverage   82.11%   82.10%   -0.01%     
==========================================
  Files          18       18              
  Lines        2756     2766      +10     
==========================================
+ Hits         2263     2271       +8     
- Misses        401      402       +1     
- Partials       92       93       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link

coveralls commented Mar 9, 2025

Pull Request Test Coverage Report for Build 13758090019

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 25 of 33 (75.76%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 85.514%

Changes Missing Coverage Covered Lines Changed/Added Lines %
exporter/exporter.go 9 10 90.0%
main.go 0 3 0.0%
exporter/keys.go 10 14 71.43%
Files with Coverage Reduction New Missed Lines %
exporter/exporter.go 1 95.3%
Totals Coverage Status
Change from base Build 13745567977: 0.02%
Covered Lines: 2373
Relevant Lines: 2775

💛 - Coveralls

@oliver006 oliver006 force-pushed the oh_add_flag_to_skip_checkkeys branch from 71755ff to aab0119 Compare March 10, 2025 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants