Skip to content

Add default top level error summary #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bdemers wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add default top level error summary #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions hooks/src/main/java/com/okta/hooks/sdk/Hooks.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ private static class DefaultBuilder implements Builder {

@Override
public Builder error(String message) {
this.error = getOrCreateError(false)
this.error = getOrCreateError(false, message)
.setErrorSummary(message);
return this;
}
Expand All @@ -90,7 +90,7 @@ public Builder errorCause(String message) {

@Override
public Builder errorCause(HookErrorCause cause) {
error = getOrCreateError(true);
error = getOrCreateError(true, cause.getErrorSummary());
error.getErrorCauses().add(cause);
return this;
}
Expand Down Expand Up @@ -139,9 +139,9 @@ public String toString() {
return SERIALIZER.serialize(build());
}

private HookError getOrCreateError(boolean initCauses) {
private HookError getOrCreateError(boolean initCauses, String errorSummary) {

HookError hookError = error != null ? error : new HookError();
HookError hookError = error != null ? error : new HookError().setErrorSummary(errorSummary);

if (initCauses && hookError.getErrorCauses() == null) {
hookError.setErrorCauses(new ArrayList<>());
Expand Down
2 changes: 1 addition & 1 deletion hooks/src/test/groovy/com/okta/hooks/sdk/TokenHooksTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class TokenHooksTest implements HooksSupport {
def builder = Hooks.builder()
.error("test-error")

def expectedToString = expected"""{"error": {"errorSummary": "test-error"}}"""
def expectedToString = expected"""{"error": { "errorSummary": "test-error"}}"""
assertThat builder.toString(), is(expectedToString)
}

Expand Down
6 changes: 3 additions & 3 deletions hooks/src/test/groovy/com/okta/hooks/sdk/UserRegHooksTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class UserRegHooksTest implements HooksSupport {
def builder = Hooks.builder()
.errorCause("test-error")

def expectedToString = expected"""{"error": {"errorCauses": [{ "errorSummary": "test-error" }]}}"""
def expectedToString = expected"""{"error": { "errorSummary": "test-error", "errorCauses": [{ "errorSummary": "test-error" }]}}"""
assertThat builder.toString(), is(expectedToString)
}

Expand All @@ -43,7 +43,7 @@ class UserRegHooksTest implements HooksSupport {
.errorCause("test-error")
.debugContext(["foo": "bar", "one": "two"])

def expectedToString = expected"""{"error": {"errorCauses": [{ "errorSummary": "test-error" }]}, "debugContext": {"foo": "bar", "one": "two"}}"""
def expectedToString = expected"""{"error": {"errorSummary": "test-error", "errorCauses": [{ "errorSummary": "test-error" }]}, "debugContext": {"foo": "bar", "one": "two"}}"""
assertThat builder.toString(), is(expectedToString)
}

Expand Down Expand Up @@ -96,7 +96,7 @@ class UserRegHooksTest implements HooksSupport {
.errorCause("test-error1")
.errorCause("test-error2")

def expectedToString = expected"""{"error": {"errorCauses": [{ "errorSummary": "test-error1" },{ "errorSummary": "test-error2" }]}}"""
def expectedToString = expected"""{"error": {"errorSummary": "test-error1", "errorCauses": [{ "errorSummary": "test-error1" },{ "errorSummary": "test-error2" }]}}"""
assertThat builder.toString(), is(expectedToString)
}

Expand Down