Skip to content

Pickup the actual username instead of login name for Github #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

vrenjith
Copy link
Contributor

@vrenjith vrenjith commented Jun 4, 2025

No description provided.

@ojacques
Copy link
Owner

ojacques commented Jun 5, 2025

Thank you for this. Would it be possible to fallback to login if name is empty / does not exist?
This will preserve earlier behavior with a nice fallback.
Ideally, a setting which will allow to choose between name and login (defaulting to login to ensure backward compatibility)

Thanks!

@vrenjith
Copy link
Contributor Author

vrenjith commented Jun 5, 2025

Thank you for this. Would it be possible to fallback to login if name is empty / does not exist? This will preserve earlier behavior with a nice fallback. Ideally, a setting which will allow to choose between name and login (defaulting to login to ensure backward compatibility)

Thanks!

  • That is a good suggestion. I just added that condition to pick up the old behaviour if the name does not exist
  • Also I added saving of the cache after every update of the internal dict. I see that it saves us because in many cases we are hitting API limits and if we have the cache saved everytime, when we rerun the whole build again, it will skip all the items which we already figured out and start from the next of files and eventually it will succeed. Let me know your comments.

@ojacques
Copy link
Owner

Again, thank you.
I tried this version, but could not find "name" to be populated in the commit informations. Do you use GitHub or GitLab?

@vrenjith
Copy link
Contributor Author

I updated the code again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants