Skip to content

Conversation

StaymanHou
Copy link

@StaymanHou StaymanHou commented Sep 13, 2021

All Submissions:

Changes proposed in this Pull Request:

For better consistency, use site_url for the rewrite_rule instead of hard-coding the path when alternate_redirect_uri is true.

The change is made primarily to fix a problem when WP_SITEURL is set to a subdirectory while alternate_redirect_uri is set to true.

How to test the changes in this Pull Request:

  1. Set WP_SITEURL to a subdirectory
  2. Check the Alternate Redirect URI option in settings
  3. Attempt a login with OpenID Connect

For better consistency, use site_url for the rewrite_rule instead of hard-coding the path when alternate_redirect_uri is true.

The change is made primarily to fix a problem when WP_SITEURL is set to a subdirectory while alternate_redirect_uri is set to true.
@timnolte timnolte self-assigned this Sep 14, 2021
@timnolte timnolte added status: needs review PR that needs review. bug labels Sep 14, 2021
@timnolte timnolte deleted the branch oidc-wp:develop December 23, 2023 00:56
@timnolte timnolte closed this Dec 23, 2023
@timnolte timnolte reopened this Dec 23, 2023
@timnolte timnolte changed the base branch from dev to develop December 23, 2023 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug status: needs review PR that needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants