Compatibility with BSD date #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The macOS shell has a different date format and does not support the uppercase shortcut.
|
Thanks! Looks good. I'll just test this still works as intended on Linux. |
oh2fih
reviewed
Mar 5, 2024
oh2fih
reviewed
Mar 5, 2024
oh2fih
reviewed
Mar 5, 2024
oh2fih
reviewed
Mar 5, 2024
oh2fih
reviewed
Mar 5, 2024
use arithmetic expressions in macOS recognition
oh2fih
reviewed
Mar 5, 2024
oh2fih
reviewed
Mar 5, 2024
Awk is already used elsewhere in the script
Use full if-then-else
|
I have fixed the issues I found. Please test whether this is still compatible with macOS. |
oh2fih
reviewed
Mar 7, 2024
The Bash on MacOS X is ancient 3.2; trying to support it will limit development of this script.
Now that Bash < 4.0 is not supported, we can revert this.
Add compatibility information.
|
This PR isn't anymore about Mac OS X shell compatibility as it originally was. Because Apple has chosen However, your contribution is still accepted with some modifications as a support for the BSD |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The macOS shell has a different date format and does not support the uppercase shortcut.