Support optional statuses on PRs #1062
Labels
Comments
xmo-odoo
added a commit
that referenced
this issue
Feb 25, 2025
If a status is defined as `optional`, then the PR is considered valid if the status is never sent, but *if* the status is sent then it becomes required. Note that as ever this is a per-commit requirement, so it's mostly useful for conditional statuses. Fixes #1062
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the mergebot only has two statuses for statuses (ignoring that statuses can be different between PRs and stagings since 5c1caa1):
However over time we've seen a new need: sub-repo statuses, which are only triggered some time (e.g. based on files touched, team, etc...) but need to block the PR if and when they are failed.
This should be pretty easy to implement: in
PullRequests._compute_statuses, the default value for a status state just needs to be provided by theStatusConfigurationobject.The text was updated successfully, but these errors were encountered: