Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show optional statuses on PR dashboard if they've been received #1066

Open
xmo-odoo opened this issue Feb 26, 2025 · 0 comments
Open

Only show optional statuses on PR dashboard if they've been received #1066

xmo-odoo opened this issue Feb 26, 2025 · 0 comments
Labels

Comments

@xmo-odoo
Copy link
Collaborator

xmo-odoo commented Feb 26, 2025

With #1062 it's now possible to have statuses which are either:

  • ignored if never sent
  • required if sent once (e.g. pending)

But currently the PR dashboard (image and page) don't differentiate, they'll display CI as valid but show an optional status as missing anyway, even when it's not required by the run e.g.

#199365

The PR in question does not auto-trigger ci/l10n and nobody has triggered it manually, so it's never sent and is not relevant to that PR, the checkbox should not appear until ci/l10n has been sent (which is a hair more complicated than the way it's handled when computing the state)

@xmo-odoo xmo-odoo moved this to accepted in Mergebot Feb 26, 2025
@xmo-odoo xmo-odoo moved this from accepted to done in Mergebot Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: done
Development

No branches or pull requests

1 participant