[IMP] server: canonicalize pattern filled paths #356
Conversation
| @@ -634,7 +634,8 @@ F: Fn(&String) -> bool, | |||
| let config_dir = config_path.parent().map(PathBuf::from).unwrap_or_else(|| PathBuf::from(".")); | |||
| if has_template(&sourced_path.value) { | |||
| return fill_validate_path(ws_folders, workspace_name, &sourced_path.value, predicate, var_map, &config_dir) | |||
| .map(|p| PathBuf::from(p).sanitize()) | |||
| .and_then(|p| std::fs::canonicalize(PathBuf::from(p)).ok()) | |||
There was a problem hiding this comment.
What is the goal of the canonicalize?
I tried using it earlier in the project, but it was too inconsistent, or can completely change your path to get you a valid one. Moreover it has a high performance cost
There was a problem hiding this comment.
I am doing to get an absolute path. to not have /../ in the path like here
it has a high cost, but it is run once just when initing. Do you think that would be considerable?
There was a problem hiding this comment.
No, here performance cost is not so important.
However I'm more afrait about the exactness of the result. With symlink for example. But I guess that would not be an issue for now as we don't support symlink at all
There was a problem hiding this comment.
@fda-odoo cannonicalize is also supposed to resolve symbolic links
No description provided.