Master carousel tabs adrm #7029
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[IMP] carousels: add dropdown when too many tabs
This commit hide the carousel tabs to prevent them from overflowing
outside of the figure, and adds the hidden tabs in a dropdown menu.
[IMP] figures: add drag threshold
When clicking on a figure, a very small mouse movement between the
mousedown and mouseup events could trigger a drag and drop operation,
canceling the click event. This is particularly annoying when trying
to interact with carousels, as they have a lot of clickable areas.
Most applications use a drag threshold, allowing small mouse movements
to be ignored. This commit adds a drag threshold for figures.
Also fixed some test that checked for the
o-dragging
class on figure.That class does not exist for figures.
[IMP] test: add
expect.toHaveStyle
jest matcherThis commit adds a custom jest matcher
toHaveStyle
to check if a DOMelement has a specific CSS style properties applied.
Task: 5059476
review checklist