[FIX] ts: fix compiling of .d.ts files
#6210
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It wasn't possible to compile the lib into `.d.ts` since 8a02a6b, error `... exported class expression may not be private or protected`.[1] It seems that we cannot have an anonymous class with private/protected methods. We had a similar issue with the `PivotPresentationLayer`. This commit adds explicit typing to the functions generating the funnel chart classes, so typescript doesn't try to infer types for them. [1]: see microsoft/TypeScript#30355 or microsoft/TypeScript#36060 Task: 0
|
|
robodoo
pushed a commit
that referenced
this pull request
Apr 30, 2025
It wasn't possible to compile the lib into `.d.ts` since 8a02a6b, error `... exported class expression may not be private or protected`.[1] It seems that we cannot have an anonymous class with private/protected methods. We had a similar issue with the `PivotPresentationLayer`. This commit adds explicit typing to the functions generating the funnel chart classes, so typescript doesn't try to infer types for them. [1]: see microsoft/TypeScript#30355 or microsoft/TypeScript#36060 closes #6210 Task: 0 Signed-off-by: Pierre Rousseau (pro) <[email protected]>
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It wasn't possible to compile the lib into
.d.tssince 8a02a6b, error... exported class expression may not be private or protected.[1]It seems that we cannot have an anonymous class with private/protected methods. We had a similar issue with the
PivotPresentationLayer.This commit adds explicit typing to the functions generating the funnel chart classes, so typescript doesn't try to infer types for them.
[1]: see microsoft/TypeScript#30355 or microsoft/TypeScript#36060
Task: 0
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist