Skip to content

Conversation

@erjer-odoo
Copy link
Contributor

Making storage categories documentation current with 18.0, requested here:: https://www.odoo.com/odoo/my-tasks/4681301

@erjer-odoo erjer-odoo self-assigned this Oct 31, 2025
@robodoo
Copy link
Collaborator

robodoo commented Oct 31, 2025

Pull request status dashboard

Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job testing doing this deep dive, @erjer-odoo !

Appreciate the strenuous testing you did and challenging my misunderstandings of the putaway behavior to result in a more accurate document! To make sure your new findings are properly highlighted, I'd like to suggest we move some things around and map out the workflows in even more detail

Let me know if I can clarify any of my comments!

@erjer-odoo erjer-odoo force-pushed the 18.0-Inventory-storage-categories-erjer branch from 1d3d322 to 1517ce9 Compare November 6, 2025 19:36
@erjer-odoo
Copy link
Contributor Author

Updated with comments from @Felicious .

@erjer-odoo erjer-odoo requested a review from Felicious November 6, 2025 19:37
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work testing this feature meticulously, @erjer-odoo !

Had super minor things I found and this PR is ready to merge

@robodoo delegate+

Comment on lines 69 to 70
- :guilabel:`Allow mixed products`: several different products can be stored in this location at
the same time.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran make review and noticed that this line ends too early. Catching my mistake from 17 months ago 😅

Suggested change
the same time.
- :guilabel:`Allow mixed products`: several different products can be stored in this location at the
same time.

Comment on lines +210 to +213
.. image:: storage_category/package-stock-move.png
:alt: Update the Stock move box to route pallets to the correct locations before validating.

- If `PAL1` and `PAL2` are full, the pallet is redirected to `WH/Stock/Pallets`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(opinion) the last bullet point gets buried and looks easy to miss below the image. It might be a little bit out of order, but what do you think about listing the partially full bullet last, and moving the "full" bullet point above the image?

Image

@Felicious Felicious added 2 3 and removed 2 labels Nov 7, 2025
@Felicious
Copy link
Contributor

I'd typically rate this as a 2pt update since it mainly brings the doc from version 18 to 19 with under 50% of the lines changed. That said, given the depth of research and testing you invested (especially around a complex feature that even the functional expert found challenging 🫶 ) I’m increasing the value to 3pts. This reflects the extra effort you put into ensuring accuracy and completeness in the original content!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants