-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[IMP] Website: update pages page #13605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @guga-odoo, thank you so much for your work on this! I added a few comments and suggestions (a few of them are actually about the same things, but I felt it was clearer if I repeated them 😉 )
Also, in general, I use the following rules to decide whether the first letter after a colon (in a list item describing a field for example) should be capitalized and should have a period at the end:
- Capitalize the first letter and add a period at the end if it's a full sentence.
- Don't capitalize and don't use a period if it's not (in this case you could use a semi-colon at the end, not mandatory though)
- If some items in the list do have a full sentence after the colon and some don't, uniformize (i.e. either use capitals/periods/semi-colons or don't use them, but don't use a mix of both in the same list). Consistency is key 🙂
I didn't add individual comments for this in this PR but could you please go through the doc and check all list (items) this might apply to? (there are a few exceptions in this doc, ofc)
Thank you!!
content/applications/websites/website/pages/page-properties.png
Outdated
Show resolved
Hide resolved
6fa449a
to
e6a70f2
Compare
task-4459299
e6a70f2
to
dfe03eb
Compare
task-4459299