Skip to content

[FW][FIX] coding_guidelines: Add comment to indicate ASCII-based ordering #12962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: saas-18.2
Choose a base branch
from

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Apr 18, 2025

Following the fix - 92c7099 Adding a comment to explicitly indicate that the import is ordered alphabetically based on ASCII values.

Forward-Port-Of: #12951

Following the fix - 92c7099
Adding a comment to explicitly indicate that the import is ordered
alphabetically based on ASCII values.

X-original-commit: a9577b5
@robodoo
Copy link
Collaborator

robodoo commented Apr 18, 2025

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Apr 18, 2025

@hamo-odoo cherrypicking of pull request #12951 failed.

stdout:

Auto-merging content/contributing/development/coding_guidelines.rst
CONFLICT (content): Merge conflict in content/contributing/development/coding_guidelines.rst

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants