18.0 tutorial module data aras

estate/__manifest__.py

@@ -8,11 +8,16 @@
     'data': [
         'security/ir.model.access.csv',
         'views/estate_property_views.xml',
-        'views/estate_property_type_views.xml',
         'views/estate_property_tag_views.xml',
         'views/estate_property_offer_views.xml',
+        'views/estate_property_type_views.xml',
         'views/estate_menus.xml',
-        'views/res_users_views.xml'
+        'views/res_users_views.xml',
+    ],
+    'demo': [
+        'demo/estate.property.type.csv',
+        'demo/estate_property.xml',
+        'demo/estate_property_offer.xml'
     ],
     'installable': True,
     'application': True,

estate/demo/estate.property.type.csv

@@ -0,0 +1,5 @@
+"id","name"
+"data_property_type_residential","Residential"
+"data_property_type_commerial","Commerial"
+"data_property_type_industrial","Industrial"
+"data_property_type_land","Land"

estate/demo/estate_property.xml

@@ -0,0 +1,57 @@
+<odoo>
+    <record id="estate_property_1" model="estate.property">
+        <field name="name">Big Villa</field>
+        <field name="description">A nice and big villa</field>
+        <field name="postcode">12345</field>
+        <field name="date_availability" eval="datetime.now() + timedelta(days=14)" />
+        <field name="expected_price">1600000</field>
+        <field name="bedrooms">6</field>
+        <field name="living_area">100</field>
+        <field name="facades">4</field>
+        <field name="garage">True</field>
+        <field name="garden">True</field>
+        <field name="garden_area">100000</field>
+        <field name="garden_orientation">south</field>
+        <field name="property_type_id" ref="data_property_type_residential"/>
+    </record>
+
+    <record id="estate_property_2" model="estate.property">
+        <field name="name">Trailer home</field>
+        <field name="state">cancelled</field>
+        <field name="description">Home in a trailer park</field>
+        <field name="postcode">54321</field>
+        <field name="date_availability" eval="datetime.now() + timedelta(days=14)" />
+        <field name="expected_price">100000</field>
+        <field name="bedrooms">1</field>
+        <field name="living_area">10</field>
+        <field name="facades">4</field>
+        <field name="property_type_id" ref="data_property_type_residential"/>
+      </record>
+
+      <record id="estate_property_3" model="estate.property">
+        <field name="name">Tutorial House</field>
+        <field name="state">offer_received</field>
+        <field name="description">X2many tutorial</field>
+        <field name="postcode">13579</field>
+        <field name="date_availability" eval="datetime.now() + timedelta(days=14)" />
+        <field name="expected_price">123456</field>
+        <field name="bedrooms">2</field>
+        <field name="living_area">30</field>
+        <field name="facades">4</field>
+        <field name="property_type_id" ref="data_property_type_residential"/>
+        <field name="offer_ids" eval="[
+            Command.clear(),
+            Command.create({
+                'partner_id': ref('base.res_partner_12'),
+                'price': 150000,
+                'validity': 14,
+            }),
+            Command.create({
+                'partner_id': ref('base.res_partner_2'),
+                'price': 150002,
+                'validity': 14,
+            }),
+        ]"/>
+      </record>
+  </odoo>
+

estate/demo/estate_property_offer.xml

@@ -0,0 +1,29 @@
+<odoo>
+    <record id="estate_property_offer_1" model="estate.property.offer">
+        <field name="partner_id" ref="base.res_partner_12"/>
+        <field name="property_id" ref="estate_property_1"/>
+        <field name="price">10000</field>
+        <field name="validity">14</field>
+        <field name="create_date" eval="datetime.now()"/>
+    </record>
+
+    <record id="estate_property_offer_2" model="estate.property.offer">
+        <field name="partner_id" ref="base.res_partner_12"/>
+        <field name="property_id" ref="estate_property_1"/>
+        <field name="price">1500000</field>
+        <field name="validity">14</field>
+        <field name="create_date" eval="datetime.now()"/>
+    </record>
+
+    <record id="estate_property_offer_3" model="estate.property.offer">
+        <field name="partner_id" ref="base.res_partner_2"/>
+        <field name="property_id" ref="estate_property_1"/>
+        <field name="price">1500001</field>
+        <field name="validity">14</field>
+        <field name="create_date" eval="datetime.now()"/>
+    </record>
+
+    <function model="estate.property.offer" name="action_offer_refuse" eval="[ref('estate_property_offer_1')]"/>
+    <function model="estate.property.offer" name="action_offer_refuse" eval="[ref('estate_property_offer_2')]"/>
+    <function model="estate.property.offer" name="action_offer_accept" eval="[ref('estate_property_offer_3')]"/>
+</odoo>

estate/models/estate_property.py

@@ -57,19 +57,21 @@ def _compute_best_price(self):
                 record.state = 'offer_received'
 
     @api.onchange("garden")
-    def _onchange_partner_id(self):
+    def _onchange_garden(self):
         for record in self:
             if record.garden:
                 record.garden_area = 10
                 record.garden_orientation = 'north'
             else:
-                record.garden_area = None
-                record.garden_orientation = None
+                record.garden_area = 0
+                record.garden_orientation = False
 
     def action_property_sold(self):
         for record in self:
             if record.state == 'cancelled':
                 raise UserError("Cancelled properties cannot be sold.")
+            elif record.state != 'offer_accepted':
+                raise UserError("You cannot sell a property without an accepted offer.")
             else:
                 record.state = 'sold'
         return True
@@ -92,6 +94,6 @@ def _check_selling_price(self):
     def unlink_if_new_or_cancelled(self):
         for record in self:
             if record.state not in ('new', 'cancelled'):
-                raise UserError("Only new and cancelled properties can be sold.")
+                raise UserError("Only new and cancelled properties can be deleted.")
             if record.offer_ids:
                 record.offer_ids.unlink()

estate/models/estate_property_offer.py

@@ -55,6 +55,9 @@ def action_offer_refuse(self):
     @api.model_create_multi
     def create(self, vals_list):
         for vals in vals_list:
+            property = self.env['estate.property'].browse(vals.get('property_id'))
+            if property.state in ('sold', 'cancelled'):
+                raise UserError(f"Cannot create an offer in a {property.state} property.")
             price = vals.get('price')
             estate_property = self.env['estate.property'].browse(vals.get('property_id'))
             if estate_property.best_price and price <= estate_property.best_price:

estate/tests/__init__.py

@@ -0,0 +1 @@
+from . import test_estate_property

estate/tests/test_estate_property.py

@@ -0,0 +1,90 @@
+from odoo.tests.common import TransactionCase
+from odoo.exceptions import UserError
+from odoo.tests import Form, tagged
+from odoo import Command
+
+
+@tagged('post_install', '-at_install')
+class EstateTestCase(TransactionCase):
+
+    @classmethod
+    def setUpClass(cls):
+        # add env on cls and many other things
+        super().setUpClass()
+
+        cls.property = cls.env['estate.property'].create([{'name': 'test_house'}])
+        cls.partner = cls.env['res.partner'].create([{
+            'name': 'test_person',
+        }])
+
+    def test_creation_area(self):
+        """Test that the total_area is computed like it should."""
+        self.property.living_area = 20
+        self.property.garden = True
+        self.property.garden_area = 15
+
+        self.assertEqual(self.property.total_area, 35)
+
+    def test_action_sell_without_accepted_offer(self):
+        """Test that everything behaves like it should when selling an invalid property."""
+
+        self.assertEqual(self.property.state, 'new')
+
+        with self.assertRaises(UserError):
+            self.property.action_property_sold()
+
+    def test_action_sell_with_accepted_offer(self):
+        """Test that everything behaves like it should when selling a valid property."""
+
+        self.property.offer_ids.create({
+            'property_id': self.property.id,
+            'partner_id': self.partner.id,
+            'price': 124,
+            'validity': 14,
+        })
+        self.property.offer_ids.action_offer_accept()
+        self.property.action_property_sold()
+
+        self.assertRecordValues(self.property, [
+           {'state': 'sold'},
+        ])
+
+    def test_creation_offer_for_sold_property(self):
+        """Test that everything behaves like it should when property is sold."""
+
+        self.property.write({'offer_ids': [Command.create({
+            'partner_id': self.partner.id,
+            'price': 124,
+            'validity': 14,
+        })]})
+        self.property.offer_ids.action_offer_accept()
+        self.property.action_property_sold()
+
+        with self.assertRaises(UserError):
+            self.property.offer_ids.create({
+                'property_id': self.property.id,
+                'partner_id': self.partner.id,
+                'price': 130,
+                'validity': 14,
+            })
+
+    def test_enable_garden(self):
+        """Test that default values are assigned to garden area and orientation when garden is enabled"""
+
+        form = Form(self.env['estate.property'])
+        form.garden = True
+
+        self.assertEqual(form.garden_area, 10)
+        self.assertEqual(form.garden_orientation, 'north')
+
+    def test_disable_garden(self):
+        """Test that values are removed from garden area and orientation when garden is disabled"""
+
+        form = Form(self.env['estate.property'])
+        form.garden = True
+        form.garden_area = 15
+        form.garden_orientation = 'south'
+        form.garden = False
+
+        self.assertEqual(form.garden_area, 0)
+        self.assertEqual(form.garden_orientation, False)