[IMP] account: Group Payment: Change memo to PAY/XXXX #4805
+14
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:18.0-rd-accounting-onboarding-malb, it needs to be retargeted before it can be merged. |
malb-odoo
reviewed
Jul 2, 2025
There was a problem hiding this comment.
For the commit title and commit message in general, let's try to follow:
https://www.odoo.com/documentation/17.0/contributing/development/git_guidelines.html
So missing task number but also commit title could just be
[IMP] account: change memo of group payment to PAY/XXXX
Appart from that the diff looks good
When creating a payment group, it generates a new payment memo using a `BATCH/XXX` prefix. It can be confusing as there is a Batch Payment feature, but it has nothing to do with it. We use `PAY/XXX` syntax for payment group. task-4908883
abmn-odoo
force-pushed
the
18.0-rd-accounting-onboarding-group-payment-memo-abmn
branch
from
8aca236 to
90840ba
Compare
malb-odoo
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[IMP] account: Group Payment: Change memo to
PAY/XXXXWhen creating a payment group, it generates a new payment memo using a
BATCH/XXXprefix.It can be confusing as there is a Batch Payment feature, but it has nothing to do with it.
We use
PAY/XXXsyntax for payment group.task-4908883